Set the GTK background color to white. #19410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
There should be a way to do this without deprecated API, though GTK follows semver, so it would never have been removed until 4. |
3 tasks
|
See alternative in #19424. |
This is consistent with the other backends (although this seems to be broken on wx too), which allows semi-transparent figures to be rendered against a consistent background (this can be checked e.g. with `figure(facecolor=(0, 0, 0, 0))` or `figure(facecolor=(1, 1, 1, .5))`), which would previously be rendered differently on gtk3 when using a dark theme.
|
I figured out how to do it with non-deprecated APIs... |
QuLogic
approved these changes
Feb 10, 2021
timhoffm
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with the other backends (although this seems to be
broken on wx too), which allows semi-transparent figures to be rendered
against a consistent background (this can be checked e.g. with
figure(facecolor=(0, 0, 0, 0))orfigure(facecolor=(1, 1, 1, .5))),which would previously be rendered differently on gtk3 when using a dark
theme.
While override_background_color is marked as deprecated on gtk3, thealternative seems to involve a bunch of CSS, and it seems unlikely to
ever be removed now that gtk development has switched to gtk4...
xref #9698.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).