Fix default label visibility for top-or-left-labeled shared subplots(). #19472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef3f42d to
78cbe1c
Compare
tacaswell
approved these changes
Feb 18, 2021
jklymak
approved these changes
Feb 18, 2021
|
Does this need a what's new in case someone had a whole song and dance to replicate this, and they can now remove it? |
On the following example
```python
from pylab import *
rcParams.update({"xtick.labeltop": 1, "xtick.labelbottom": 0,
"ytick.labelright": 1, "ytick.labelleft": 0})
subplots(3, 3, sharex=True, sharey=True)
```
subplots() now correctly leaves the xlabels on the first row and the
ylabels on the last column, rather than the other way round.
On the following example
```python
from pylab import *
rcParams.update({"xtick.labeltop": 1, "xtick.labelbottom": 1,
"ytick.labelright": 1, "ytick.labelleft": 1})
subplots(3, 3, sharex=True, sharey=True)
show()
```
subplots() now correctly leaves the xlabels on the first and last row
and the ylabels on the first and last column.
|
done |
78cbe1c to
6a9e339
Compare
|
Anyone can merge post-CI |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the following example
subplots() now correctly leaves the xlabels on the first row and the
ylabels on the last column, rather than the other way round.
old:
new:
On the following example
subplots() now correctly leaves the xlabels on the first and last row
and the ylabels on the first and last column.
old:
new:
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).