Skip to content

fix regression of axline behavior with non-linear scales #19485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

johan12345
Copy link
Contributor

PR Summary

#18647 broke loglog scale axlines (see #19445). This PR fixes it by adding transScale to the transformations applied to the points of the line and adds a test to verify the result (based on the example given by @anntzer in #19445).

This should have no effect on results with linear scales, and the remaining tests are still passing, so it looks like it works correctly.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related. [N/A]
  • Documentation is sphinx and numpydoc compliant (the docs should build without error). [N/A]
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all). [N/A]
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). [N/A]
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). [N/A]

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the quick fix!
The approval is modulo @jklymak's style fix.

@anntzer anntzer added this to the v3.4.0 milestone Feb 9, 2021
@QuLogic QuLogic merged commit e24244c into matplotlib:master Feb 10, 2021
@tacaswell
Copy link
Member

Thank you @johan12345 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants