Deprecate unused \*args to print_<foo>. #19487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
274153e to
273fd2d
Compare
timhoffm
approved these changes
Mar 10, 2021
QuLogic
reviewed
Mar 10, 2021
|
I updated the PR as well as the commit message, also at the top of the thread, to address both points. |
QuLogic
reviewed
Mar 10, 2021
These `*args` are never used. gtk3agg's print_png can just be directly inherited from agg (likely, it is a remnant of a time when gtk3 would rely on cairo's png output by default). For the pgf backend, `*args` can be directly deleted because it would previously have caused exceptions when forwarded to _print_pgf_to_fh.
QuLogic
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
*argsare never used.gtk3agg's print_png can just be directly inherited from agg (likely, it
is a remnant of a time when gtk3 would rely on cairo's png output by
default).
For the pgf backend,
*argscan be directly deleted because it wouldpreviously have caused exceptions when forwarded to _print_pgf_to_fh.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).