MNT: Restore auto-adding Axes3D to their parent figure on init #19496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This passes the labelled test if you go back to the old way of calling: @mpl3d_image_comparison(['axes3d_labelpad.png'], remove_text=False)
def test_axes3d_labelpad():
fig = plt.figure()
ax = Axes3D(fig)OTOH, I was hoping we would deprecate calling Axes3D this way because it really is illogical to have it behave differently from every other type of axes. |
d96fa55 to
f1938e8
Compare
7 tasks
jklymak
reviewed
Feb 17, 2021
QuLogic
approved these changes
Feb 17, 2021
Only warn when directly created by the user, not via our machinery. Closes matplotlib#18939 Co-authored-by: Jody Klymak <jklymak@gmail.com> Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
2262017 to
8d10261
Compare
|
I think I fixed the doc build (by updating a very old whats new example!). |
jklymak
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only do this when directly created by the user, not via our machinery.
PR Summary
Alternative to #19413.
This still needs tests and updates to the docs.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).