Skip to content

Dedupe implementations of {XAxis,YAxis}._get_tick_boxes_siblings. #19498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 11, 2021

A single implementation can be written in the base class.

Also, the alignment groupers only need to be defined in FigureBase;
we don't need to redefine them in the Figure subclass.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer added topic: geometry manager LayoutEngine, Constrained layout, Tight layout Maintenance labels Feb 11, 2021
@anntzer anntzer force-pushed the gtbs branch 3 times, most recently from b5671ea to 24fb288 Compare February 11, 2021 16:13
A single implementation can be written in the base class.

Also, the alignment groupers only need to be defined in FigureBase;
we don't need to redefine them in the Figure subclass.
@timhoffm timhoffm added this to the v3.4.0 milestone Feb 17, 2021
@timhoffm timhoffm merged commit 140ed40 into matplotlib:master Feb 17, 2021
@anntzer anntzer deleted the gtbs branch February 17, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance topic: geometry manager LayoutEngine, Constrained layout, Tight layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants