Skip to content

Fully fold overset/underset into _genset. #19499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2021
Merged

Fully fold overset/underset into _genset. #19499

merged 1 commit into from
May 20, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 11, 2021

No need to repeat the tokens expansion twice, and it seems reasonable
enough to check the string itself instead of inventing a separate
parameter just to pass the information of whether an overset or an
underset is being handled.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Fully fold overset/underset into _genset.
5b78b6f 
No need to repeat the tokens expansion twice, and it seems reasonable
enough to check the string itself instead of inventing a separate
parameter just to pass the information of whether an overset or an
underset is being handled.
aitikgupta
aitikgupta approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@aitikgupta aitikgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that my review would count to an approval, but looks good to me!

@story645 story645 merged commit aec7ec8 into matplotlib:master May 20, 2021
@anntzer anntzer deleted the overunder branch May 20, 2021 21:07
@QuLogic QuLogic added this to the v3.5.0 milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@story645 story645 story645 approved these changes

@aitikgupta aitikgupta aitikgupta approved these changes

Assignees
No one assigned
Labels
Maintenance topic: text/mathtext
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @story645 @aitikgupta