Skip to content

Remove workaround for numpy<1.16, and update version check. #19500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2021
Merged

Remove workaround for numpy<1.16, and update version check. #19500

merged 3 commits into from
Feb 16, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 11, 2021

We now require numpy 1.16 (per setup.py and NEP29).

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Remove workaround for numpy<1.16, and update version check.
e8d9ea3 
We now require numpy 1.16 (per setup.py and NEP29).
@anntzer anntzer added this to the v3.4.0 milestone Feb 11, 2021
@tacaswell
Copy link
Member

Apparently I missed these in 60b03f1 / #17662 and there is already an API note change included in that PR (which I noted after I helpfully pushed a commit to this branch to add one 🤦 ).

Also pushed a commit bumping the run-time version of pyparsing and dateutil.

@timhoffm
Copy link
Member

timhoffm commented Feb 16, 2021 •
edited
Loading

Also pushed a commit bumping the run-time version of pyparsing and dateutil.

Are these based on

We will only bump these dependencies as we need new features or the old versions no longer support our minimum NumPy or Python.

?

@tacaswell
Copy link
Member

Yes, the setup.py versions of dateutil and pyparsing were both bumped in #17662 (to the oldest version that did not have deprecation warnings on py36 (I think importing without warnings is a defend-able definition of "support" because otherwise we would have to protect their imports to keep our tests passing). See dd61ed1 and cfccfb8 for details.

@timhoffm timhoffm merged commit d235b02 into matplotlib:master Feb 16, 2021
@anntzer anntzer deleted the np116 branch February 16, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @timhoffm @QuLogic