Remove remaining references to Travis CI #19504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8d082d to
d6a2ce4
Compare
d6a2ce4 to
827d86b
Compare
dstansby
approved these changes
Feb 12, 2021
timhoffm
reviewed
Feb 15, 2021
| # rebuild the cache and try again. | ||
| fm._rebuild() | ||
| assert Path(findfont(fp)).name == "wqy-zenhei.ttc" | ||
| pytest.skip("Font may be missing") |
There was a problem hiding this comment.
Are we sure, we can drop skipping on sys.platform != "linux"?
There was a problem hiding this comment.
We only needed the second half of that or to allow the skip to happen on the mac on travis. I think this is OK, but I'm going to push a commit to this branch to install zenhei on azure for linux and OSX.
tacaswell
approved these changes
Feb 16, 2021
timhoffm
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As in title.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).