BUG: fill_between with interpolate=True and NaN. #19534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Feb 18, 2021
|
Test was failing on np 1.16 as comparisons like I've dealt with this by wrapping the comparisons |
jklymak
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #18986
Fixes a bug in
fill_betweenwhen usinginterpolate=Truewith NaNs and/or masked arrays (issue #18986).Here
matplotlib/lib/matplotlib/axes/_axes.py
Lines 5269 to 5271 in 140ed40
we correctly convert the input arrays
ind,dep1anddep1to masked arrays, but a few lines latermatplotlib/lib/matplotlib/axes/_axes.py
Line 5288 in 140ed40
the
np.broadcast_arrayscall converts the masked arrays back to normalndarrays. The subsequentnp.ma.is_maskedtest fails and the fill is rendered incorrectly.The fix is simple, I've added the kwarg
subok=Trueto thebroadcast_arrayscall which preserves the masked arrays.I've added a new test based on the OP's example, and the existing test images for
test_axes/fill_between_interpolateare now correct. We are unlucky not to have spotted this before but it is not surprising, there are only a few erroneous pixels on the left-hand side corresponding to the first element being masked.OP's script now produces the correct result:
PR Checklist
pytestpasses).flake8on changed files to check).