Share subplots() label visibility handling with label_outer(). #19540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Feb 19, 2021
QuLogic
reviewed
Feb 19, 2021
|
oops. fixed, with a test. |
|
Code coverage appears to be saying that there should be a test for when the |
This allows label_outer() to also benefit from handling of top-or-right labeled axes (not only for the tick labels, but also for the axis labels themselves).
|
fixed coverage. |
QuLogic
approved these changes
Mar 1, 2021
jklymak
reviewed
Mar 21, 2021
| self.set_xlabel("") | ||
| self.xaxis.set_tick_params(which="both", labeltop=False) | ||
| if self.xaxis.offsetText.get_position()[1] == 1: | ||
| self.xaxis.offsetText.set_visible(False) |
There was a problem hiding this comment.
This is because moving offset texts is somewhat broken anyways (#19471).
jklymak
reviewed
Mar 21, 2021
| self.set_ylabel("") | ||
| self.yaxis.set_tick_params(which="both", labelright=False) | ||
| if self.yaxis.offsetText.get_position()[0] == 1: | ||
| self.yaxis.offsetText.set_visible(False) |
jklymak
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows label_outer() to also benefit from handling of top-or-right
labeled axes (not only for the tick labels, but also for the axis labels
themselves).
followup to #19472.
edit: this should also be useful for #18305.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).