Skip to content

DOC: fix typos #19567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2021
Merged

DOC: fix typos #19567

merged 3 commits into from
Feb 25, 2021

Conversation

katrielester
Copy link
Contributor

PR Summary

Several typos fixed. Typos are found using codespell.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two non-agg spelling mistakes are fine, but I think we just vendor agg, so I wouldn't change those just for the sake of making code spell happy.

@katrielester katrielester requested a review from jklymak February 25, 2021 09:13
@tacaswell tacaswell added this to the v3.4.0 milestone Feb 25, 2021
@tacaswell tacaswell merged commit ce7d1cb into matplotlib:master Feb 25, 2021
@tacaswell
Copy link
Member

Agree with @jklymak about not changing the vendored code.

Thank you for this @katrielester ! Congratulations on your first Matplotlib PR 🎉 Hopefully we will hear from you again.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 25, 2021
tacaswell added a commit that referenced this pull request Feb 25, 2021
…567-on-v3.4.x

Backport PR #19567 on branch v3.4.x (DOC: fix typos)
@katrielester katrielester deleted the my-new-feature branch February 26, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants