Fail early when setting Text color to a non-colorlike. #19571
Merged
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but |
Otherwise, the error is only raised when drawing the artist, which is always confusing. Also add a general `_check_color_like` mechanism and use it for Line2D as well, instead of relying on a slightly strange `if not is_color_like(): check_in_list(get_named_colors_mapping())` call where the check_in_list *always* fails.
|
Yes...? |
|
Thats what the original bug was failing on, wasn't it? |
|
Given that the traceback ends with |
jklymak
approved these changes
Feb 26, 2021
timhoffm
approved these changes
Feb 27, 2021
|
Don't see why this has to go in v3.4.1. @meeseeksdev backport to v3.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 1, 2021
… non-colorlike.
tacaswell
added a commit
that referenced
this pull request
Mar 2, 2021
…571-on-v3.4.x Backport PR #19571 on branch v3.4.x (Fail early when setting Text color to a non-colorlike.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the error is only raised when drawing the artist, which is
always confusing. Also add a general
_check_color_likemechanism anduse it for Line2D as well, instead of relying on a slightly strange
if not is_color_like(): check_in_list(get_named_colors_mapping())call where the check_in_list always fails.
Closes #19569 (well, likely the OP was confused about other stuff, but this should at least bring the error message closer to the relevant place).
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).