Deprecate Text.get_prop_tup. #19575
Merged
Deprecate Text.get_prop_tup. #19575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Feb 27, 2021
QuLogic
approved these changes
Mar 1, 2021
get_prop_tup was intended as a general caching mechanism for reusing Text layouts, but it ended up only being used by _get_layout (which backends have to call anyways to handle multiline text). Note that in fact, if we really wanted to make backends use that info for caching, whether e.g. the text color needs to be taken into account would likely depend on the backend's own caching mechanism. Replace it by a private `_get_layout_cache_key`, which does not take color into account (color doesn't affect layout), which will later allow removing a color-must-be-hashable check.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_prop_tup was intended as a general caching mechanism for reusing
Text layouts, but it ended up only being used by _get_layout (which
backends have to call anyways to handle multiline text). Note that in
fact, if we really wanted to make backends use that info for caching,
whether e.g. the text color needs to be taken into account would likely
depend on the backend's own caching mechanism.
Replace it by a private
_get_layout_cache_key, which does not takecolor into account (color doesn't affect layout), which will later allow
removing a color-must-be-hashable check.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).