Add kerning to single-byte strings in PDFs #19582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! This changes 10 PDF tests, so those images will have to be updated. There is also a flake8 error. |
b30d609 to
08f03c1
Compare
|
The failing PDF tests were actually a string encoding issue on my side. I've fixed this now, and improved the code style. |
anntzer
reviewed
Mar 1, 2021
anntzer
reviewed
Mar 1, 2021
08f03c1 to
f179cce
Compare
anntzer
reviewed
Mar 1, 2021
anntzer
approved these changes
Mar 1, 2021
f179cce to
b555611
Compare
|
Don't forget to mark this ready for review. |
aitikgupta
reviewed
Mar 2, 2021
QuLogic
reviewed
Mar 3, 2021
b555611 to
4881758
Compare
4881758 to
1251563
Compare
QuLogic
approved these changes
Mar 4, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 4, 2021
tacaswell
added a commit
that referenced
this pull request
Mar 4, 2021
…582-on-v3.4.x Backport PR #19582 on branch v3.4.x (Add kerning to single-byte strings in PDFs)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR #18517 adds kerning to strings in PDFs if the string contains multi-byte chars. In case of strings consisting only of single-byte chars, the PDF output does not contains kerning (PDF operator
Tj). This PR adds kerning to the single-byte case and adds the string using theTJoperator. See also #19581.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).