Skip to content

Clean up E265 in examples. #19626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 3, 2021

PR Summary

For some reason we ignore E265 (block comment must start with # ), but not E264 (inline comment must start with # ). This is the first step in rectifying that discrepancy.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added this to the v3.5.0 milestone Mar 3, 2021
@QuLogic QuLogic force-pushed the fix-examples-e265 branch from 7c42397 to 657cee9 Compare March 3, 2021 23:36
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anybody can merge after CI pass.

@timhoffm timhoffm modified the milestones: v3.5.0, v3.4-doc Mar 3, 2021
@QuLogic QuLogic merged commit a3d30a3 into matplotlib:master Mar 4, 2021
@QuLogic QuLogic deleted the fix-examples-e265 branch March 4, 2021 01:25
@QuLogic QuLogic modified the milestones: v3.4-doc, v3.5.0 Mar 13, 2021
@QuLogic QuLogic mentioned this pull request Apr 7, 2021
3 tasks
@QuLogic QuLogic mentioned this pull request May 28, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants