Skip to content

Fix Bbox.frozen() not copying minposx/minposy #19641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Fix Bbox.frozen() not copying minposx/minposy #19641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0153828
Add test testing #19296
m4reko Mar 2, 2021
90fcad6
Add overriding frozen function to Bbox
m4reko Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/matplotlib/tests/test_transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,12 @@ def assert_bbox_eq(bbox1, bbox2):
assert_array_equal(bbox1.bounds, bbox2.bounds)


def test_bbox_frozen_copies_minpos():
bbox = mtransforms.Bbox.from_extents(0.0, 0.0, 1.0, 1.0, minpos=1.0)
frozen = bbox.frozen()
assert_array_equal(frozen.minpos, bbox.minpos)


def test_bbox_intersection():
bbox_from_ext = mtransforms.Bbox.from_extents
inter = mtransforms.Bbox.intersection
Expand Down
6 changes: 6 additions & 0 deletions lib/matplotlib/transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,12 @@ def invalidate(self):
self._check(self._points)
super().invalidate()

def frozen(self):
# docstring inherited
frozen_bbox = super().frozen()
frozen_bbox._minpos = self.minpos.copy()
return frozen_bbox

@staticmethod
def unit():
"""Create a new unit `Bbox` from (0, 0) to (1, 1)."""
Expand Down