Skip to content

Make the travis output quieter on v1.2.x #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2013

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented May 1, 2013

@pelson: You may be interested in this.

I have also done another version of this on master (since .travis.yml has diverged a lot) as part of #1951.

# This is a workaround to install numpy with the version of
# virtualenv in Travis. If that is updated in the future, this can
# be simplified to 'pip install numpy'
- 'if [ $TRAVIS_PYTHON_VERSION == "3.2" ]; then pip install https://github.com/y-p/numpy/archive/1.6.2_with_travis_fix.tar.gz; fi'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked intentional, though I've no idea why it was here. I guess so long as the test all pass it is fine (this is just .travis.yml after all!).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numpy 1.6.2 was released with a bug that made it incompatible with Python 3.2 on Travis, so we explicitly linked to a patched version. Now that Numpy 1.7 is out and is the default one gets from pip, there's no longer a need for this hack.

mdboom added a commit that referenced this pull request May 1, 2013
Make the travis output quieter on v1.2.x
@mdboom mdboom merged commit 51d1d87 into matplotlib:v1.2.x May 1, 2013
- if [[ $TRAVIS_PYTHON_VERSION == '2.'* ]]; then pip install --use-mirrors PIL; fi
- sudo apt-get update && sudo apt-get install inkscape
- pip -q install --use-mirrors nose numpy
- if [[ $TRAVIS_PYTHON_VERSION == '2.'* ]]; then pip -q install --use-mirrors PIL; fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been meaning to bring this up on the mailing list but PIL is a dead horse IMHO. Pillow seems to be the actively developed fork (I've had changes merged very quickly in pillow recently) so I wonder if we can get rid of the if statement and use is on all Python versions: https://pypi.python.org/pypi/Pillow/ .

Lets keep that out of this PR though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah -- maybe we should open an issue about moving to Pillow.

@dmcdougall dmcdougall mentioned this pull request Jun 18, 2013
@mdboom mdboom deleted the simplify-travis branch August 7, 2014 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants