Dedupe various method implementations using functools.partialmethod. #19654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Mar 6, 2021
QuLogic
reviewed
Mar 9, 2021
This is shorter and yields better signatures on the resulting methods (as partialmethod forwards to the signature of the underlying helper). For example, the signature of FigureCanvasCairo.print_ps is now `(self, fobj, *, orientation='portrait')` rather than `(self, fobj, *args, **kwargs)`. For the cairo/wx print_foos, also note that we can delete the `*args` in the various print methods with no deprecation as they were not supported to start with (the underlying call to `_save` and `_print_image` would have raised if such `*args` were passed in).
QuLogic
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is shorter and yields better signatures on the resulting methods
(as partialmethod forwards to the signature of the underlying helper).
For example, the signature of FigureCanvasCairo.print_ps is now
(self, fobj, *, orientation='portrait')rather than(self, fobj, *args, **kwargs).For the cairo/wx print_foos, also note that we can delete the
*argsinthe various print methods with no deprecation as they were not supported
to start with (the underlying call to
_saveand_print_imagewouldhave raised if such
*argswere passed in).PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).