Allow PolygonSelector points to be removed #19660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbd648d to
11e69e5
Compare
11e69e5 to
4c4f33a
Compare
QuLogic
reviewed
Apr 6, 2021
| if self._nverts <= 2: | ||
| # If only one point left, return to un-complete state to let user | ||
| # start drawing again | ||
| self._polygon_completed = False |
4c4f33a to
ed2ab4b
Compare
|
Thanks for the review. I've:
|
QuLogic
approved these changes
Apr 6, 2021
4 tasks
d09cffa to
0554f6e
Compare
|
@jklymak was this marked as a draft because it needed a rebase (now done), or is there something else? |
|
Just the rebase. When looking at old PRs it is easy to hit "draft:false" in the search terms. It is not easy to put "not:label" for the 10 labels that indicate author action needed. |
|
👍, just checking |
|
... when you clear the "needs rebase" totally feel free to move back to "Ready for Review". Its just a way to keep things off the radar until the author has cleared the issue. Our PR backlog is still too big for this to be super effective, but I go through once a week or so and try and sort another dozen or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This allows one to remove individual points of a
PolygonSelectorby right-clicking on them (mouse button 3).PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).