Skip to content

DOC: fix dx in Arrow guide #19707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Mar 15, 2021

PR Summary

The arrow guide mistakenly made it sound like the arguments for FancyArrowPatch are (x, y) and (dx, dy), whereas they are (x_tail, y_tail) and (x_head, y_head).

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak jklymak requested a review from dstansby March 15, 2021 05:55
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dstansby dstansby added this to the v3.4.1 milestone Mar 15, 2021
@dstansby dstansby merged commit 200ebe1 into matplotlib:master Mar 15, 2021
@QuLogic QuLogic modified the milestones: v3.4.1, v3.4.0 Mar 15, 2021
@QuLogic
Copy link
Member

QuLogic commented Mar 15, 2021

@meeseeksdev backport to v3.4.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 15, 2021
QuLogic added a commit that referenced this pull request Mar 16, 2021
…707-on-v3.4.x

Backport PR #19707 on branch v3.4.x (DOC: fix dx in Arrow guide)
@jklymak jklymak deleted the doc-arrow-more branch March 16, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants