wx backend changes for wxPython Phoenix #1974
Conversation
| import wx.aui | ||
| print wx.VERSION_STRING | ||
|
|
||
| import wx.lib.agw.aui as aui |
There was a problem hiding this comment.
On 07/05/2013 12:52, Phil Elson wrote:
In examples/user_interfaces/embedding_in_wx5.py:
import wx
-import wx.aui
+print wx.VERSION_STRING
+
+import wx.lib.agw.aui as auiDoes this work with v2.8?
I testet with 2.8.12.1, as per changes.html in 2.8.12:
2.8.9.2
- 16-Feb-2009
Added the wx.lib.agw package ........
So, only as of 2.8.9+ will it work, if that is not acceptable that one
could do:
if 'phoenix' in wx.PlatformInfo:
import wx.lib.agw.aui as aui
else:
import wx.aui as aui
Werner
There was a problem hiding this comment.
A more general way to handle it would be
try:
import wx.lib.agw.aui as aui
except ImportError:
import wx.aui as auiConflicts: examples/user_interfaces/embedding_in_wx5.py lib/matplotlib/backends/backend_wx.py
|
@wernerfb, it is good to see this work. |
|
Hi Eric, On 11/05/2013 23:53, Eric Firing wrote:
If I understand your suggestion correctly, I should use "rebase" on my Werner |
|
Werner, yes, you would rebase on current master and make a new pull request with master as the base. Be sure to use a feature branch, however--see http://matplotlib.org/devel/index.html for some workflow tips. I think it would be by far the best if you could build mpl locally, so you could fully test your changes in the normal way. Also, because this involves testing with a very new and not widely distributed version of wx, it might take a while before others are able to test it, so maybe the 1.3 target is too optimistic. There have been quite a few changes in backend_wx* from 1.2.x to master, and it looks like more are needed even without the Phoenix compatibility changes. I'm not sure whether it would be better to try to use git to rebase, or whether it might be easier to essentially re-do the changes directly on master. If you run into trouble with the former, you can always fall back on the latter. I think there may be quite a bit of testing and work required to make sure these sorts of changes work on sufficiently old versions of wx--and some thought may need to go into the question of how old a version we need to support here. |
|
It looks like the rebase was clean, I'll push that in a little while. I don't think I will find time in the near future to figure out what I need to build 1.3 locally (don't I need a C compiler etc etc), are there preview builds for win 32 I could maybe use? It would be great if this would make it into 1.3 and as the latest changes should be compatible with wxPython 2.8+ classic and 2.9.5 Phoenix this should be possible no? At least this way it gets more testing, even if mostly with wxPython classic. |
I used embedding_in_wx5 for testing and tested against 2.8.12 and 2.95 preview classic and 2.95 Phoenix (snapshot 2.9.5.81 r73883).
Worked against tag 1.2.0 which is what I have installed (Win 7), hope this is fine.