FIX: do not report that webagg supports blitting #19762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Mar 24, 2021
timhoffm
reviewed
Mar 24, 2021
| @@ -116,6 +116,7 @@ def _timer_set_interval(self): | |||
|
|
|||
| class FigureCanvasWebAggCore(backend_agg.FigureCanvasAgg): | |||
| _timer_cls = TimerTornado | |||
| supports_blit = False | |||
There was a problem hiding this comment.
Do you want to add a comment that this is a workaround, or is this tracked in an issue and planned to be fixed soon after 3.4 release?
There was a problem hiding this comment.
Added an inline comment.
We now implement the required underlying methods (copy_from_bbox and restore_region), but there are issues with the double buffering in nbagg, initialization issues, and with updates to the front end being dropped. For mpl3.4.0 over-ride the class property that checks for the required methods until we can fix the issues with blitting. Closes matplotlib#19701
768c676 to
0c2ae15
Compare
|
The issue with blitting / stale draws is tracked in #19116 |
jklymak
approved these changes
Mar 24, 2021
|
@meeseeksdev backport to v3.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 24, 2021
timhoffm
added a commit
that referenced
this pull request
Mar 24, 2021
…762-on-v3.4.x Backport PR #19762 on branch v3.4.x (FIX: do not report that webagg supports blitting)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now implement the required underlying methods (copy_from_bbox and
restore_region), but there are issues with the double buffering in nbagg,
initialization issues, and with updates to the front end being dropped.
For mpl3.4.0 over-ride the class property that checks for the required methods
until we can fix the issues with blitting.
Closes #19701
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).