Skip to content

Fix code-of-conduct link on doc homepage. #19786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 27, 2021

PR Summary

The link is not modified by Sphinx and just goes to ../CODE_OF_CONDUCT.md, which doesn't exist in the Sphinx docs.

I already directly patched this on the docs repo after building 3.4.0 docs.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • [n/a] Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added this to the v3.4-doc milestone Mar 27, 2021
@timhoffm timhoffm merged commit fe27023 into matplotlib:master Mar 27, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 27, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 27, 2021
timhoffm added a commit that referenced this pull request Mar 28, 2021
…786-on-v3.4.0-doc

Backport PR #19786 on branch v3.4.0-doc (Fix code-of-conduct link on doc homepage.)
timhoffm added a commit that referenced this pull request Mar 28, 2021
…786-on-v3.4.x

Backport PR #19786 on branch v3.4.x (Fix code-of-conduct link on doc homepage.)
@QuLogic QuLogic deleted the fix-conduct-link branch April 16, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants