Skip to content

Fix antialiasing with old pycairo/cairocffi. #19817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 30, 2021

PR Summary

The cairo.Antialias Enum was added in pycairo 1.13, but we support 1.11. It also appears to not exist in cairocffi (Kozea/cairocffi#183).

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

The `cairo.Antialias` Enum was added in pycairo 1.13, but we support
1.11. It also appears to not exist in cairocffi.
@QuLogic QuLogic added this to the v3.4.1 milestone Mar 30, 2021
@QuLogic QuLogic requested a review from anntzer March 30, 2021 00:30
@anntzer
Copy link
Contributor

anntzer commented Mar 30, 2021

oops, thanks for catching that.

@anntzer anntzer merged commit db2eac3 into matplotlib:master Mar 30, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 30, 2021
tacaswell added a commit that referenced this pull request Mar 30, 2021
…817-on-v3.4.x

Backport PR #19817 on branch v3.4.x (Fix antialiasing with old pycairo/cairocffi.)
@QuLogic QuLogic deleted the cairo-antialias-compat branch March 30, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants