Correct handle default backend. #19855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See comments in `matplotlib/__init__.py` and `setup.py`. Test by updating your local repo to this branch and `pip install git+file:///path/to/repo` (doing so with the current master throws `ValueError: Key backend: '' is not a valid value for backend`.
tacaswell
approved these changes
Apr 2, 2021
|
This is a better solution that what I proposed. |
|
PS: I would still like to deprecate letting the packager set the default backend (perhaps I should just have quietly left it broken ;-)), but we can discuss that on another thread, perhaps. |
dstansby
approved these changes
Apr 3, 2021
|
This works for our CI downstream. Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments in
matplotlib/__init__.pyandsetup.py. Testby updating your local repo to this branch and
pip install git+file:///path/to/repo(doing so with the current master throwsValueError: Key backend: '' is not a valid value for backend.Closes #19848, see #19854 for an alternate approach, but see also #19854 (comment).
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).