Cleanup docstrings related to interactive mode #19863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
commented
Apr 4, 2021
Comment on lines
+1145
to
+1146
| This function is only intended for use in backends. End users should | ||
| use `.pyplot.isinteractive` instead. |
There was a problem hiding this comment.
As far as I understand this, interactive mode does not make sense without pyplot (without a figure manager no updates are done anyway).
There was a problem hiding this comment.
I suppose this should indicate why, and the one in pyplot should also link back here for backends.
timhoffm
commented
Apr 4, 2021
| ret = gca().text(*args, **kwargs) | ||
| draw_if_interactive() | ||
| return ret | ||
| return gca().text(*args, **kwargs) |
There was a problem hiding this comment.
This was outdated. There is no explicit draw_if_interactive() involved anymore.
tacaswell
approved these changes
Apr 6, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 6, 2021
QuLogic
added a commit
that referenced
this pull request
Apr 7, 2021
…863-on-v3.4.x Backport PR #19863 on branch v3.4.x (Cleanup docstrings related to interactive mode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.