Don't set zoom/pan cursor for non-navigatable axes. #19904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Apr 8, 2021
Putting the case where a tool is active first avoids negated conditions (e.g. re: event.inaxes), making things easier to follow. Also, let SetCursorBase keep a reference to the currently active tool, rather than its cursor, to avoid having the slightly confusing `._cursor` next to `._default_cursor` and `._last_cursor`.
Zoom/pan cannot be used e.g. on colorbars, which are "non-navigatable". So don't set the zoom/pan cursor when the mouse is over them, either.
QuLogic
approved these changes
Apr 8, 2021
timhoffm
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
first commit:
Putting the case where a tool is active first avoids negated conditions
(e.g. re: event.inaxes), making things easier to follow.
Also, let SetCursorBase keep a reference to the currently active tool,
rather than its cursor, to avoid having the slightly confusing
._cursornext to._default_cursorand._last_cursor.second commit:
Zoom/pan cannot be used e.g. on colorbars, which are "non-navigatable".
So don't set the zoom/pan cursor when the mouse is over them, either.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).Putting the case where a tool is active first avoids negated conditions
(e.g. re: event.inaxes), making things easier to follow.
Also, let SetCursorBase keep a reference to the currently active tool,
rather than its cursor, to avoid having the slightly confusing
._cursornext to._default_cursorand._last_cursor.