Skip to content

FIX: subfigure indexing error #19949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2021
Merged

FIX: subfigure indexing error #19949

merged 1 commit into from
Apr 20, 2021

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Apr 12, 2021

PR Summary

Closes #19947.

The indexing to locate subfigures was wildly off. Worked fine for 2x2 but was incorrect for anything larger.

This PR fixes that and adds a test.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak jklymak added this to the v3.4.2 milestone Apr 12, 2021
@jklymak jklymak added topic: geometry manager LayoutEngine, Constrained layout, Tight layout Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Apr 12, 2021
@jklymak jklymak force-pushed the fix-subfigure-indexing branch from 33c25c6 to 704a37c Compare April 12, 2021 16:20
@jklymak
Copy link
Member Author

jklymak commented Apr 12, 2021

Failing mac tests are not this PR

QuLogic
QuLogic approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor inconsistencies.

@jklymak jklymak force-pushed the fix-subfigure-indexing branch from 072e7c0 to b1651f4 Compare April 14, 2021 05:10
@jklymak jklymak requested a review from timhoffm April 16, 2021 17:25
@anntzer anntzer merged commit 6015417 into matplotlib:master Apr 20, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 20, 2021
@anntzer @meeseeksmachine
Backport PR matplotlib#19949: FIX: subfigure indexing error
dc8fa2d
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 20, 2021
Merged
QuLogic added a commit that referenced this pull request Apr 20, 2021
@QuLogic
Merge pull request #20022 from meeseeksmachine/auto-backport-of-pr-19…
e39fbb6 
…949-on-v3.4.x

Backport PR #19949 on branch v3.4.x (FIX: subfigure indexing error)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm Awaiting requested review from timhoffm

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: geometry manager LayoutEngine, Constrained layout, Tight layout
Projects
None yet
Milestone
v3.4.2
Development

Successfully merging this pull request may close these issues.

Figure.subfigures dont show/update correctly
4 participants
@jklymak @QuLogic @anntzer @timhoffm