-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
- wxPython Phoenix #1995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- wxPython Phoenix #1995
Conversation
@@ -1052,7 +1051,10 @@ def start_event_loop(self, timeout=0): | |||
bind(self, wx.EVT_TIMER, self.stop_event_loop, id=id) | |||
|
|||
# Event loop handler for start/stop event loop | |||
self._event_loop = wx.EventLoop() | |||
if 'phoenix' in wx.PlatformInfo: | |||
self.event_loop = wx.GUIEventLoop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be self._event_loop
(leading underscore)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am just testing again against Phoenix and I never get to that line. Do you know when/why start_event_loop method should fire?
This replaces #1974, so I am closing that one. |
I'll work on the other embedding_in_wx examples to make them compatible with Phoenix, but don't have much time this week, hopefully by the end of next week, will at that point update this PR |
- additional updates to examples and set them to default to 2.8
A Sage user commented that one couldn't make plots in Sage "sage". But this is a color. http://xkcd.com/color/rgb/ recommends the following, and the discussion at https://groups.google.com/forum/#!topic/sage-devel/CnH45Ym4zSk indicates it could be useful as well as fun.
Fix backend_svg.RendererSVG.draw_text to render urls
@wernerfb Any progress on this? In any case, this will need a rebase. |
Add "sage" colors to colors.py
- additional updates to examples and set them to default to 2.8
…tlib into wxPython-Phoenix
I rebased and updated my Phoenix copy to the snapshot for wxPython Phoenix 3.0 of Jan 5.2014. I can run all embedding_in_wx?.py and close them if I try to resize the frame I get exceptions "AttributeError: 'MyApp' object has no attribute 'ProcessIdle'" which I will need to research some more. The exception is thrown on different lines when I run the same module - so a bit confusing. I am still using mpl 1.2.0, so need to update that before I can test this further. |
@wernerfb It looks like you did a merge instead of a re-base. By merging the |
Hhm, I am pretty sure I did a rebase, but wouldn't put my hand into the fire:), as git is still confusing me. Will look into this when I get a moment to upgrade my matplot install. |
This still needs to be cleaned up. You need to
|
Sorry for delay was away without internet access. The 'reset' leaves me with un-commited stuff which has nothing to do with what I worked on. |
This is replaced by PR #2803 |
Changes for wxPython Phoenix compatibility, only tested against 1.2.0 install on Win 32. Tested against wxPython 2.8.12.1, 2.9.5 classic and 2.9.5 phoenix, use a recent snapshot build from http://wxpython.org/Phoenix/snapshot-builds/
It should be compatible with wxPython 2.8+ classic.