-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
fixed bug in CenteredNorm, issue #19972 #19978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A test is needed IMHO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should add a test here - there is code in the original issue (#19972) that should be fine.
👍 This can go in on one review once a test is aded. |
Sorry, I was away for the weekend. Happy to add a test. Basically one that recreates the circumstances of the reported bug, I presume? |
While the reported bug (#19972) raised an exception, the underlying issue was that the coded tested for |
Ping @dstansby |
@meeseeksbot backport to v3.4.x |
@meeseeksdev backport to v3.4.x |
PR Summary
Fixed the CenteredNorm bug in issue #19972
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).