Setting dashes to (0,0) results in infinite loop for agg backends #1999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rephorm: Can you please confirm that the attached patch resolves your problem? |
|
👍 - this is good to merge. |
mdboom
added a commit
that referenced
this pull request
May 14, 2013
Setting dashes to (0,0) results in infinite loop for agg backends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other backends may also be affected. I have not tested exhaustively.
It would be good to check in GraphicsContextBase.set_dashes that dash_list is not all 0's. Some backends (cairo and gdk) override set_dashes, so those may need to be modified as well.