Don't hide shared "x/y"ticklabels for grids of non-rectilinear axes. #19994
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Apr 16, 2021
https://matplotlib.org/stable/gallery/specialty_plots/skewt.html would be a counter example. OTOH, it's correct for all built in projections, and if somebody provides a custom projection we can expect they'll be able to hide labels they do not want. So let's not overthink this. |
|
Fair point about skewT :( but I would agree that they can always hide the labels themselves. |
|
feel free to remilestone |
QuLogic
approved these changes
May 6, 2021
In particular, hiding the "x/y" (i.e. theta/r) ticklabels doesn't make sense for polar axes, and I'd guess likewise for most projections other than the default rectilinear. Try e.g. `subplots(2, 2, subplot_kw=dict(projection="polar"), sharex=True, sharey=True)`.
|
rebased |
|
This broke on merge, possibly because of the grid visibility PR #20161 going in in between. |
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, hiding the "x/y" (i.e. theta/r) ticklabels doesn't make
sense for polar axes, and I'd guess likewise for most projections other
than the default rectilinear. Try e.g.
subplots(2, 2, subplot_kw=dict(projection="polar"), sharex=True, sharey=True).before:
after:
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).