Fix removal of shared polar axes. #20009
Merged
+56
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Apr 20, 2021
There's really two separate fixes here:
- Move isDefault_{maj,min}{loc,fmt} tracking to the Ticker instances,
where they logically belong (note the previous need to additionally
track them manually on axes removal, when that info was tracked on
the Axis). This has the side effect of fixing removal of sharex'd
polar axes, as ThetaLocators rely on _AxisWrappers which don't have
that isDefault attribute. (Note that the patch would have resulted
in a net decrease of lines of code if it didn't need to maintain
backcompat on isDefault_foos).
- Ensure that RadialLocator correctly propagates Axis information to
the linear locator it wraps (consistently with ThetaLocator), so that
when an axes is removed the wrapped linear locator doesn't stay
pointing at an obsolete axes. This, together with the first patch,
fixes removal of sharey'd polar axes.
|
feel free to remilestone |
timhoffm
approved these changes
Apr 29, 2021
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
|
thanks @timhoffm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's really two separate fixes here:
Move isDefault_{maj,min}{loc,fmt} tracking to the Ticker instances,
where they logically belong (note the previous need to additionally
track them manually on axes removal, when that info was tracked on
the Axis). This has the side effect of fixing removal of sharex'd
polar axes, as ThetaLocators rely on _AxisWrappers which don't have
that isDefault attribute. (Note that the patch would have resulted
in a net decrease of lines of code if it didn't need to maintain
backcompat on isDefault_foos). Closes Removal of x-shared polar axes causes crash #19988. Split out of Allow sharing Locators and Formatters across Axises. #13482.
Ensure that RadialLocator correctly propagates Axis information to
the linear locator it wraps (consistently with ThetaLocator), so that
when an axes is removed the wrapped linear locator doesn't stay
pointing at an obsolete axes. This, together with the first patch,
fixes removal of sharey'd polar axes. Closes Removal of y-shared polar axes causes crash at draw time #19989.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).