Skip to content

Shorten the repr of scaling transforms. #20028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 20, 2021

Scaling transforms (with just nonzero diagonal terms) are quite common,
and special-casing them makes many transform reprs shorter, helping with
debugging. See e.g. changes in the test_transforms reference output.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Scaling transforms (with just nonzero diagonal terms) are quite common,
and special-casing them makes many transform reprs shorter, helping with
debugging.  See e.g. changes in the test_transforms reference output.
@jklymak
Copy link
Member

jklymak commented Apr 20, 2021

Anyone should merge once docs build.

@timhoffm timhoffm added this to the v3.5.0 milestone Apr 20, 2021
@timhoffm timhoffm merged commit e96a88e into matplotlib:master Apr 20, 2021
@anntzer anntzer deleted the trr branch April 20, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants