Skip to content

Cleanup widget examples #20031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2021
Merged

Cleanup widget examples #20031

merged 1 commit into from
Apr 21, 2021

Conversation

timhoffm
Copy link
Member

PR Summary

  • don't use 90ish background color. The default style is good enough (actually better IMHO).
  • In the span selector:
    • '-' is the default style. We don't need to specify it explicitly.
    • It's more logical that the bottom "selected region" plot is empty at the beginning, when nothing has been selected so far.
    • Use blue as a selection color (Nicer appearance IMHO)
    • Some variable renaming.

@timhoffm timhoffm added this to the v3.4.2 milestone Apr 20, 2021
@QuLogic QuLogic merged commit 45031fd into matplotlib:master Apr 21, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 21, 2021
@QuLogic @meeseeksmachine
Backport PR matplotlib#20031: Cleanup widget examples
2da9837
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 21, 2021
Merged
@timhoffm timhoffm deleted the doc-widget-style branch April 21, 2021 06:20
timhoffm added a commit that referenced this pull request Apr 21, 2021
@timhoffm
Merge pull request #20033 from meeseeksmachine/auto-backport-of-pr-20…
6d64b2e 
…031-on-v3.4.x

Backport PR #20031 on branch v3.4.x (Cleanup widget examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@timhoffm @QuLogic