-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: fix typos #20042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: fix typos #20042
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1272,7 +1272,7 @@ def __init__(self, vcenter, vmin=None, vmax=None): | |
Defaults to the min value of the dataset. | ||
vmax : float, optional | ||
The data value that defines ``1.0`` in the normalization. | ||
Defaults to the the max value of the dataset. | ||
Defaults to the max value of the dataset. | ||
|
||
Examples | ||
-------- | ||
|
@@ -1739,7 +1739,7 @@ def __call__(self, value, clip=None): | |
else: | ||
max_col = self.Ncmap | ||
# this gives us the bins in the lookup table in the range | ||
# [0, _n_regions - 1] (the offset is baked in in the init) | ||
# [0, _n_regions - 1] (the offset is baked in the init) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not a typo. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prob should be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixing this in a follow-up PR since this one was merged before I could address it. |
||
iret = np.digitize(xx, self.boundaries) - 1 + self._offset | ||
# if we have more colors than regions, stretch the region | ||
# index computed above to full range of the color bins. This | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better just delete this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure, I can also mimic the neighboring comments with
# check if each item is artist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's basically what the code does; there's no point in having the comment.