Support SubFigures in AxesDivider. #20073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
e773520 to
09115c3
Compare
|
That's just s-g and subfigures not playing well together; I guess here I just needed to have a single block from the pov of s-g so that it shows the whole figure at the end. |
|
Looks good. But I looked at this for a few minutes, and still can't guess how that code makes a 2x2 grid, or what nx, ny etc are. Since you must understand it at this point, can you add a few more comments explaining it? |
|
Does https://57381-1385122-gh.circle-artifacts.com/0/doc/build/html/tutorials/toolkits/axes_grid.html#axesdivider help a bit? (I think I'd rather get the tutorial clear and not try to explain the same thing in multiple places) |
|
... sure, but maybe link the tutorial here? |
43402a2 to
3362976
Compare
|
Sure. |
7969538 to
3b727b6
Compare
jklymak
approved these changes
Apr 26, 2021
|
rebased |
QuLogic
approved these changes
May 13, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #20069 (comment).
Goes on top of #20069 and #20072. The example now gives
Writing a test specifically for this case is currently left as an exercise to the reader...
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).