Skip to content

Expire Artist.set() property reordering #20077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

timhoffm
Copy link
Member

PR Summary

Expired deprecation.

@timhoffm timhoffm added this to the v3.5.0 milestone Apr 25, 2021
@timhoffm timhoffm force-pushed the expire-artist-set-order branch from 2652a98 to 0d89637 Compare April 25, 2021 21:00
@jklymak
Copy link
Member

jklymak commented Apr 25, 2021

This makes sense to me - where was the deprecation though?

@timhoffm
Copy link
Member Author

timhoffm commented Apr 25, 2021

where was the deprecation though?

What do you mean? In the removed code. ❓

@jklymak
Copy link
Member

jklymak commented Apr 25, 2021

Yes, if it was deprecated, presumably there was a message somewhere?

@timhoffm timhoffm force-pushed the expire-artist-set-order branch from 0d89637 to c316bd1 Compare April 25, 2021 22:43
@timhoffm
Copy link
Member Author

Yes. lines 1170-1176?

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, reading too fast!

@QuLogic QuLogic merged commit c65140f into matplotlib:master Apr 26, 2021
@timhoffm timhoffm deleted the expire-artist-set-order branch April 26, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants