Skip to content

ci: Bump Ubuntu to 18.04 LTS. #20154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2021
Merged

ci: Bump Ubuntu to 18.04 LTS. #20154

merged 5 commits into from
May 13, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented May 4, 2021 •
edited
Loading

PR Summary

Ubuntu 16.04 LTS went EOL at the end of April 2021.

Fixes #19494.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • [n/a] Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
ci: Bump Ubuntu to 18.04 LTS.
7247b1c 
Ubuntu 16.04 LTS went EOL at the end of April 2021.
@QuLogic QuLogic added this to the v3.5.0 milestone May 4, 2021
QuLogic added 3 commits May 4, 2021 01:15
@QuLogic
Update mixedmode test result.
87a9b4f 
Presumably some external dependency has changed the result, likely
Ghostscript. This has been broken on Fedora for some time, but we never
updated it because CI was on Ubuntu 16.04.
@QuLogic
TST: Ignore Producer key mismatches in PGF metadata.
ea09d95 
Some LaTeX engines ignore the setting of this key in hyperref, but
otherwise obey the request metadata. This is likely still okay, but
leave a note in the docs as well.
@QuLogic
ci: Upload result images if tests fail.
bb52af0
@QuLogic
Copy link
Member Author

QuLogic commented May 5, 2021

The EPS failures are a bit strange, and sporadic:

$ identify result_images/test_backend_ps/type3*
result_images/test_backend_ps/type3.eps PS 576x432 576x432+0+0 16-bit sRGB 4651B 0.000u 0:00.000
result_images/test_backend_ps/type3_eps.png PNG 595x842 595x842+0+0 8-bit sRGB 5736B 0.000u 0:00.000
result_images/test_backend_ps/type3-expected.eps PS 576x432 576x432+0+0 16-bit sRGB 4651B 0.000u 0:00.000
result_images/test_backend_ps/type3-expected_eps.png PNG 612x792 612x792+0+0 8-bit sRGB 5456B 0.000u 0:00.000

They're both the same size as EPS, but different size when converted to PNG. Also, previous commits failed more jobs than the current one, with the EPS failures, so it seems a bit flaky.

@QuLogic
ci: Invalidate Matplotlib caches on test runners.
ab053fd 
These store files that were created with older versions of system
dependencies, so need to be regenerated.
@QuLogic
Copy link
Member Author

QuLogic commented May 5, 2021

OK, I realized we cache ~/.cache/matplotlib on runners, and since conversions of expected test images to .png would be using different system latex/ghoscript/inkscape/etc., those caches needed to be invalidated. This should fix the random .eps test failures (which probably only passed when the cache was too big and happened to drop those files by chance).

@QuLogic QuLogic marked this pull request as ready for review May 5, 2021 09:13
@anntzer
Copy link
Contributor

anntzer commented May 5, 2021

Possibly consider having an 20.04 job? per #19255 (comment) and following comments...

@QuLogic
Copy link
Member Author

QuLogic commented May 6, 2021

I tried that just now, but there are a couple issues. Something seems wrong with coverage, possibly to do with parallel tests, but I have not investigated. There are failures in some tests; this is good for me since they've been broken on Fedora with newer dependencies, but it won't be equal to the Ubuntu 18.04 tests.

I think I'll open the 20.04 changes in a separate PR.

@jklymak jklymak merged commit 81f0624 into matplotlib:master May 13, 2021
@QuLogic QuLogic deleted the ubuntu18 branch May 13, 2021 19:25
@QuLogic QuLogic mentioned this pull request May 14, 2021
Merged
3 tasks
@QuLogic
Copy link
Member Author

QuLogic commented May 26, 2021

@meeseeksdev backport to v3.4.x

@QuLogic QuLogic modified the milestones: v3.5.0, v3.4.3 May 26, 2021
@meeseeksmachine meeseeksmachine mentioned this pull request May 26, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request May 26, 2021
@jklymak @meeseeksmachine
Backport PR matplotlib#20154: ci: Bump Ubuntu to 18.04 LTS.
1ef141e
QuLogic added a commit that referenced this pull request May 26, 2021
@QuLogic
Merge pull request #20307 from meeseeksmachine/auto-backport-of-pr-20…
02088df 
…154-on-v3.4.x

Backport PR #20154 on branch v3.4.x (ci: Bump Ubuntu to 18.04 LTS.)
@QuLogic
Copy link
Member Author

QuLogic commented Jun 7, 2021

@meeseeksdev backport to v3.4.2-doc

@meeseeksmachine meeseeksmachine mentioned this pull request Jun 7, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 7, 2021
@jklymak @meeseeksmachine
Backport PR matplotlib#20154: ci: Bump Ubuntu to 18.04 LTS.
ddf292c
tacaswell added a commit that referenced this pull request Jun 8, 2021
@tacaswell
Merge pull request #20384 from meeseeksmachine/auto-backport-of-pr-20…
ed3bd51 
…154-on-v3.4.2-doc

Backport PR #20154 on branch v3.4.2-doc (ci: Bump Ubuntu to 18.04 LTS.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Maintenance topic: testing
Projects
None yet
Milestone
v3.4.3
Development

Successfully merging this pull request may close these issues.

Update azure ubuntu images to 18.04, or update texlive in CI
4 participants
@QuLogic @anntzer @tacaswell @jklymak