Move axisartist towards using standard Transforms. #20207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axisartist can generate "slanted" or "curved" axes defined using either a custom Transform, or a custom pair of callables (forward, backward) which define the Transform. Instead of repeatedly testing the two cases in `transform_xy` and `inv_transform_xy`, just wrap the pair-of-callables into a custom Transform subclass (which should probably not be moved to the main library, as it uses the transposed convention compared to the usual one), and expose it through a getter. This allows later combining this transform using "standard" transform addition (and get benefits such as single multiplication of matrices in affine transforms, exact cancellation of inverses, or (later) more accurate transforming of arcs in polar transforms), instead of having to manually call successive transforms. See e.g. the two changes in the local transform_xy definitions.
QuLogic
approved these changes
May 13, 2021
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
jklymak
approved these changes
May 13, 2021
|
I agree, but I'm hoping that gap may be easier to bridge if we slowly nudge axisartist towards being "more standard" as well... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axisartist can generate "slanted" or "curved" axes defined using either
a custom Transform, or a custom pair of callables (forward, backward)
which define the Transform. Instead of repeatedly testing the two cases
in
transform_xyandinv_transform_xy, just wrap thepair-of-callables into a custom Transform subclass (which should
probably not be moved to the main library, as it uses the transposed
convention compared to the usual one), and expose it through a getter.
This allows later combining this transform using "standard" transform
addition (and get benefits such as single multiplication of matrices
in affine transforms, exact cancellation of inverses, or (later) more
accurate transforming of arcs in polar transforms), instead of having to
manually call successive transforms. See e.g. the two changes in the
local transform_xy definitions.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).