Skip to content

Clarify docstring of ScalarMappable.set/get_array() #20238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2021

Conversation

timhoffm
Copy link
Member

PR Summary

  • "image array" is too narrow as most children of ScalarMappable are no images.
  • It is important to note that we don't imply any shape or dimensionality of the array in the base class.

@timhoffm timhoffm added this to the v3.4.3 milestone May 15, 2021
@jklymak jklymak merged commit 75c425c into matplotlib:master May 16, 2021
@lumberbot-app
Copy link

lumberbot-app bot commented May 16, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.4.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 75c425c425d5d4914133cb935a3419e2ad1b6116
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #20238: Clarify docstring of ScalarMappable.set/get_array()'
  1. Push to a named branch :
git push YOURFORK v3.4.x:auto-backport-of-pr-20238-on-v3.4.x
  1. Create a PR against branch v3.4.x, I would have named this PR:

"Backport PR #20238 on branch v3.4.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@jklymak
Copy link
Member

jklymak commented May 16, 2021

@timhoffm I don't see why this needs to be in 3.4.3 so I'm re-milestoning. But feel free to do the back port if you would like.

@jklymak jklymak modified the milestones: v3.4.3, v3.5.0 May 16, 2021
@timhoffm timhoffm deleted the doc-set_array branch May 16, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants