-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix legend edgecolor face #20260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix legend edgecolor face #20260
Conversation
55c24d1
to
1cb7a78
Compare
lib/matplotlib/legend_handler.py
Outdated
@@ -749,6 +749,9 @@ def get_first(prop_array): | |||
return None | |||
edgecolor = getattr(orig_handle, '_original_edgecolor', | |||
orig_handle.get_edgecolor()) | |||
if edgecolor == 'face': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note we can't just get rid of the line before as it causes some hatching tests to fail for some reason...
#8575 put in the mysterious fix for the hatching. Strangely, although |
Thanks - we could also do
Or fix it in |
Third commit checks for no colors... |
Closes matplotlib#20258. Alternative to matplotlib#20260.
Close in favour of #20265 |
Closes matplotlib#20258. Alternative to matplotlib#20260.
PR Summary
Closes #20258
Passing
'face'
to a polygon that would show up in the legend would not be recognized. Now it is...before:
Now:
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).