Fix exception handling when constructing C-level PathGenerator. #20343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PathGenerator constructor does not set a Python-level exception on failure. Switch to use a PyArg_ParseTuple-style converter to get proper error handling. (Also, CALL_CPP already converts py::exception to Python-level exceptions, so it doesn't need to be wrapped in a C++-level try... catch.)
tacaswell
approved these changes
Jun 2, 2021
jklymak
reviewed
Jun 2, 2021
| @@ -333,12 +333,13 @@ PyRendererAgg_draw_path_collection(PyRendererAgg *self, PyObject *args, PyObject | |||
| PyObject *offset_position; // offset position is no longer used | |||
|
|
|||
| if (!PyArg_ParseTuple(args, | |||
| "O&O&OO&O&O&O&O&O&O&O&OO:draw_path_collection", | |||
| "O&O&O&O&O&O&O&O&O&O&O&OO:draw_path_collection", | |||
There was a problem hiding this comment.
I don't know what these strings are. Was this just a typo before?
There was a problem hiding this comment.
No, this needs to be changed because I added &convert_pathgen. See https://docs.python.org/3/extending/extending.html#extracting-parameters-in-extension-functions
QuLogic
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PathGenerator constructor does not set a Python-level exception on
failure. Switch to use a PyArg_ParseTuple-style converter to get proper
error handling.
(Also, CALL_CPP already converts py::exception to Python-level
exceptions, so it doesn't need to be wrapped in a C++-level try...
catch.)
Closes https://gitter.im/matplotlib/matplotlib?at=60b71b8478e1d6477d7ad9a3
(well, the C error handling part at least).
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).