ENH: expose make_norm_from_scale #20405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e26432 to
8b69d27
Compare
QuLogic
reviewed
Jun 19, 2021
Comment on lines
4
to
5
| Downstream libraries can take advantage of ``make_norm_from_scale`` in | ||
| ``colors.py`` to create a `~.colors.Normalize` subclass directly from |
There was a problem hiding this comment.
Probably should just make this a full-on reference?
There was a problem hiding this comment.
Yeah, for some reason that wasn't working...
There was a problem hiding this comment.
Ah, an entry needs to be added to doc/api/colors_api.rst.
There was a problem hiding this comment.
I think this still needs to be changed to e.g.
take advantage of `.colors.make_norm_from_scale`?
8b69d27 to
ee98a5d
Compare
72ac1cf to
28b9e4e
Compare
QuLogic
approved these changes
Jul 6, 2021
anntzer
reviewed
Jul 19, 2021
| ``colors.py`` to create a `~.colors.Normalize` subclass directly from | ||
| an existing scale. Usually norms have a scale, and the advantage of | ||
| having a `~.scale.ScaleBase` attached to a norm is to provide a | ||
| default scale for the colorbar. |
There was a problem hiding this comment.
perhaps be more explicit: "provide a scale, and associated tick locators and formatters, for the colorbar"
anntzer
approved these changes
Jul 19, 2021
28b9e4e to
4ec0bc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Internally we now make most norms from scales using
colors._make_norm_from_scale. This simply hoists that to public API so downstream libraries can use it as well...PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).