Use packaging to do version comparisons. #20437
Merged
+39
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
commented
Jun 15, 2021
| # https://github.com/ImageMagick/ImageMagick/issues/2720 | ||
| raise ExecutableNotFoundError( | ||
| f"You have ImageMagick {info.version}, which is unsupported") | ||
| return info | ||
| elif name == "pdftops": | ||
| info = impl(["pdftops", "-v"], "^pdftops version (.*)", | ||
| ignore_exit_code=True) | ||
| if info and not ("3.0" <= info.version | ||
| # poppler version numbers. | ||
| or "0.9" <= info.version <= "1.0"): |
There was a problem hiding this comment.
Note the <= 1.0 was an incorrect conversion from 32ed5bd
|
Hmm, guess I need to actually fix compatibility with old |
|
looks like you either need to replace |
|
I looked through downstream distributions and the ones that are at least close to latest Matplotlib have at least |
tacaswell
approved these changes
Jun 17, 2021
... as `distutils` is deprecated in Python 3.10. The minimum is ~a year ago, which appears to be available in all distros that are close to current in Matplotlib.
anntzer
approved these changes
Jun 19, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
... as
distutilsis deprecated in Python 3.10.Since this is somewhat lower-level, I picked a minimum version on the same timescale as Python support, namely about 3 years ago.Minimum version is ~12 months ago, since this is a Python-only package and all relevant downstreams appear to have it.Maybe this should get an API note or something?
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).