Skip to content

Suppress repeated logwarns in postscript output. #20449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Suppress repeated logwarns in postscript output. #20449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions lib/matplotlib/backends/backend_ps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,21 @@ def __init__(self, width, height, pswriter, imagedpi=72):
self._path_collection_id = 0

self._character_tracker = _backend_pdf_ps.CharacterTracker()
self._logwarn_once = functools.lru_cache(None)(_log.warning)

def _is_transparent(self, rgb_or_rgba):
if rgb_or_rgba is None:
return True # Consistent with rgbFace semantics.
elif len(rgb_or_rgba) == 4:
if rgb_or_rgba[3] == 0:
return True
if rgb_or_rgba[3] != 1:
self._logwarn_once(
"The PostScript backend does not support transparency; "
"partially transparent artists will be rendered opaque.")
return False
else: # len() == 3.
return False

def set_color(self, r, g, b, store=True):
if (r, g, b) != self.color:
Expand Down Expand Up @@ -457,7 +472,7 @@ def draw_markers(

ps_color = (
None
if _is_transparent(rgbFace)
if self._is_transparent(rgbFace)
else '%1.3f setgray' % rgbFace[0]
if rgbFace[0] == rgbFace[1] == rgbFace[2]
else '%1.3f %1.3f %1.3f setrgbcolor' % rgbFace[:3])
Expand Down Expand Up @@ -552,7 +567,7 @@ def draw_path_collection(self, gc, master_transform, paths, all_transforms,
def draw_tex(self, gc, x, y, s, prop, angle, *, mtext=None):
# docstring inherited
if not hasattr(self, "psfrag"):
_log.warning(
self._logwarn_once(
"The PS backend determines usetex status solely based on "
"rcParams['text.usetex'] and does not support having "
"usetex=True only for some elements; this element will thus "
Expand Down Expand Up @@ -589,7 +604,7 @@ def draw_tex(self, gc, x, y, s, prop, angle, *, mtext=None):
def draw_text(self, gc, x, y, s, prop, angle, ismath=False, mtext=None):
# docstring inherited

if _is_transparent(gc.get_rgb()):
if self._is_transparent(gc.get_rgb()):
return # Special handling for fully transparent.

if ismath == 'TeX':
Expand Down Expand Up @@ -729,10 +744,10 @@ def _draw_ps(self, ps, gc, rgbFace, *, fill=True, stroke=True):
"""
write = self._pswriter.write
mightstroke = (gc.get_linewidth() > 0
and not _is_transparent(gc.get_rgb()))
and not self._is_transparent(gc.get_rgb()))
if not mightstroke:
stroke = False
if _is_transparent(rgbFace):
if self._is_transparent(rgbFace):
fill = False
hatch = gc.get_hatch()

Expand Down Expand Up @@ -769,21 +784,6 @@ def _draw_ps(self, ps, gc, rgbFace, *, fill=True, stroke=True):
write("grestore\n")


def _is_transparent(rgb_or_rgba):
if rgb_or_rgba is None:
return True # Consistent with rgbFace semantics.
elif len(rgb_or_rgba) == 4:
if rgb_or_rgba[3] == 0:
return True
if rgb_or_rgba[3] != 1:
_log.warning(
"The PostScript backend does not support transparency; "
"partially transparent artists will be rendered opaque.")
return False
else: # len() == 3.
return False


@_api.deprecated("3.4", alternative="GraphicsContextBase")
class GraphicsContextPS(GraphicsContextBase):
def get_capstyle(self):
Expand Down
7 changes: 4 additions & 3 deletions lib/matplotlib/tests/test_backend_ps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,11 @@ def test_failing_latex():
@needs_usetex
def test_partial_usetex(caplog):
caplog.set_level("WARNING")
plt.figtext(.5, .5, "foo", usetex=True)
plt.figtext(.1, .1, "foo", usetex=True)
plt.figtext(.2, .2, "bar", usetex=True)
plt.savefig(io.BytesIO(), format="ps")
assert caplog.records and all("as if usetex=False" in record.getMessage()
for record in caplog.records)
record, = caplog.records # asserts there's a single record.
assert "as if usetex=False" in record.getMessage()


@image_comparison(["useafm.eps"])
Expand Down