-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Remove remaining 3.3 deprecations #20465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
60d4906
Remove case-insensitivity deprecated in 3.3.
QuLogic b2667e8
Remove animation bits deprecated in 3.3.
QuLogic c51ae6d
Remove artist-specific deprecations from 3.3.
QuLogic 372741c
Remove Bezier and Path deprecations from 3.3.
QuLogic bb978a4
Remove transforms API deprecated in 3.3.
QuLogic aec7bb4
Remove testing and doc API deprecated in 3.3.
QuLogic 19da8c3
Remove widget API deprecated in 3.3.
QuLogic b04f1a3
Remove ToolManager API deprecated in 3.3.
QuLogic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,93 @@ | ||||||
Case-insensitive properties | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
Upper or mixed-case property names are no longer normalized to lowercase in | ||||||
`.Artist.set` and `.Artist.update`. This allows one to pass names such as | ||||||
*patchA* or *UVC*. | ||||||
|
||||||
Case-insensitive capstyles and joinstyles | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
Please pass capstyles ("miter", "round", "bevel") and joinstyles ("butt", | ||||||
"round", "projecting") as lowercase. | ||||||
|
||||||
AVConv animation writers removed | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
The ``AVConvBase``, ``AVConvWriter`` and ``AVConvFileWriter`` classes, and the | ||||||
associated ``animation.avconv_path`` and ``animation.avconv_args`` rcParams | ||||||
have been removed. | ||||||
|
||||||
Debian 8 (2015, EOL 06/2020) and Ubuntu 14.04 (EOL 04/2019) were the | ||||||
last versions of Debian and Ubuntu to ship avconv. It remains possible | ||||||
to force the use of avconv by using the FFmpeg-based writers with | ||||||
:rc:`animation.ffmpeg_path` set to "avconv". | ||||||
|
||||||
``MovieWriter`` attributes | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
* ``animation.html_args`` rcParam | ||||||
* ``HTMLWriter.args_key`` attribute | ||||||
* ``MovieWriter.args_key`` and ``MovieWriter.exec_key`` attributes | ||||||
* *clear_temp* parameter and attribute of `.FileMovieWriter`; files placed in a | ||||||
temporary directory (using ``frame_prefix=None``, the default) will be | ||||||
cleared; files placed elsewhere will not. | ||||||
|
||||||
Artist-specific removals | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
* Setting a custom method overriding `.Artist.contains` using | ||||||
``Artist.set_contains`` has been removed, as has ``Artist.get_contains``. | ||||||
There is no replacement, but you may still customize pick events using | ||||||
`.Artist.set_picker`. | ||||||
* Passing the dash offset as ``None`` is no longer accepted, as this was never | ||||||
universally implemented, e.g. for vector output. Set the offset to 0 instead. | ||||||
* The parameter *props* of `.Shadow` has been removed. Use keyword arguments | ||||||
instead. | ||||||
* Arbitrary keyword arguments to ``StreamplotSet`` have no effect and have been | ||||||
removed. | ||||||
* ``NonUniformImage.is_grayscale`` and ``PcolorImage.is_grayscale`` attributes | ||||||
have been removed, for consistency with ``AxesImage.is_grayscale``. (Note | ||||||
that previously, these attributes were only available *after rendering the | ||||||
image*). | ||||||
|
||||||
Path helpers | ||||||
~~~~~~~~~~~~ | ||||||
* ``bezier.make_path_regular``; use ``Path.cleaned()`` (or | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
``Path.cleaned(curves=True)``, etc.) instead, but note that these methods add | ||||||
a ``STOP`` code at the end of the path. | ||||||
* ``bezier.concatenate_paths``; use ``Path.make_compound_path()`` instead. | ||||||
* *quantize* parameter of `.Path.cleaned()` | ||||||
|
||||||
``BboxBase.inverse_transformed`` | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
|
||||||
``.BboxBase.inverse_transformed`` has been removed (call `.BboxBase.transformed` | ||||||
on the `~.Transform.inverted()` transform instead). | ||||||
|
||||||
``matplotlib.test(recursionlimit=...)`` | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
The *recursionlimit* parameter of `matplotlib.test` has been removed. | ||||||
|
||||||
``testing.compare.make_external_conversion_command`` | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
... has been removed. | ||||||
|
||||||
``docstring.Substitution.from_params`` | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
This method has been removed. If needed, directly assign to the ``params`` | ||||||
attribute of the Substitution object. | ||||||
|
||||||
``widgets.TextBox.params_to_disable`` | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
This attribute has been removed. | ||||||
|
||||||
`.widgets.SubplotTool` callbacks and axes | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
The ``funcleft``, ``funcright``, ``funcbottom``, ``functop``, ``funcwspace``, | ||||||
and ``funchspace`` methods of `.widgets.SubplotTool` have been removed. | ||||||
|
||||||
The ``axleft``, ``axright``, ``axbottom``, ``axtop``, ``axwspace``, and | ||||||
``axhspace`` attributes of `.widgets.SubplotTool` have been removed. Access | ||||||
the ``ax`` attribute of the corresponding slider, if needed. | ||||||
|
||||||
Variants on ``ToolManager.update_keymap`` calls | ||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||
Passing multiple keys as a single comma-separated string or multiple arguments | ||||||
to `.ToolManager.update_keymap` is no longer supported; pass keys as a list of | ||||||
strings instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO for clarity, we should take the effort and make full sentences. Also in the following bullet points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit lazier here because a) this is in the removal section, so it's implied, and b) I re-edit these when I put together final release notes and they may or may not be re-grouped, and then will get an overall sentence then.