Skip to content

give Font a root widget #20476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2021
Merged

give Font a root widget #20476

merged 1 commit into from
Jun 21, 2021

Conversation

richardsheridan
Copy link
Contributor

Fixes toolbar for tk.NoDefaultRoot() users.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@richardsheridan
give Font a root widget
d4bcdd0 
Fixes toolbar for tk.NoDefaultRoot() users
@QuLogic QuLogic added this to the v3.5.0 milestone Jun 21, 2021
@timhoffm timhoffm merged commit f230dfb into matplotlib:master Jun 21, 2021
@richardsheridan richardsheridan deleted the tk_font_root branch June 21, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: tk
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richardsheridan @QuLogic @timhoffm