Deprecate :encoding: option to .. plot::, which has no effect since 2011 #20540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Its value is not read anywhere in the implementation since a205f54.)
timhoffm
approved these changes
Jun 28, 2021
QuLogic
reviewed
Jun 29, 2021
| @@ -194,6 +194,11 @@ def _option_format(arg): | |||
| return directives.choice(arg, ('python', 'doctest')) | |||
|
|
|||
|
|
|||
| def _deprecated_option_encoding(arg): | |||
| _api.warn_deprecated("3.5", "encoding", obj_type="option") | |||
There was a problem hiding this comment.
Considering the error in #20543, it looks like this is missing a name=?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Its value is not read anywhere in the implementation since a205f54.)
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).